Repository navigation
fix(bin): debounce Helm unsupported-repository wakes - #25
Merged
geojitsu merged 3 commits intoSep 14, 2026
Merged
Conversation
added 3 commits
September 14, 2026 03:05
Almost every fleet check woke the captain with the same "unsupported repository <repo> for <id>; using other" line, for the same already-known tasks, over and over. Two gaps compounded: the note had no per-task marker like every other "already told you" fact in this sync, so it reprinted on every full replan (and any unrelated backlog change invalidates the whole-fleet debounce hash that gates a replan); and fm-helm-watch.sh treated any output other than its three exact silent shapes as wake-worthy, so this note - and the equally benign "another Helm sync is already running" lock-contention message - turned an otherwise clean run into a wake. fm_helm_plan_program now debounces the note through the same divergence-memory marker shape already used for every other field divergence in this file: state/.helm-unsupported-repo, keyed on task id and the exact repo: value. It fires once per distinct value and again only when that value actually changes. fm-helm-watch.sh no longer treats either informational message as wake-worthy on its own: both are stripped from a run's combined output before the existing silent-shape check runs, so a clean run carrying only one of them stays silent. Tests: an unsupported repo: value fires its note and leaves a durable marker on first sight, an unrelated backlog change that forces a full replan does not re-fire it, and changing the task's own repo: value does re-fire it with the new value. The watcher stays silent on a run whose only unusual output is this note (even on a task's first sync) or the lock-contention message. Out of scope: the hard-coded six-project allowlist behind this note, and the fleet-scale latency headroom gap noted alongside it - both separate, already-tracked follow-ups. Claude-Session: https://claude.ai/code/session_01D6aRxhU8ZgvecqNC4qbPcx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix the noisy "unsupported repository" wake in Helm sync so it stops pinging the captain on almost every fleet check for the same already-known fact.
What Changed
Risk Assessment
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
bin/fm-helm-lib.sh:659- The new marker serializes the rawrepo:value as TSV. A validly parsed unsupported value containing an embedded tab is written astask\t\t<repo-prefix>\t<repo-suffix>; on the next run the loader retains only field 3 asfp, so it no longer matches the full value and the note re-fires on every replan. Encode or hash the repo fingerprint before storing and compare that encoded value.🔧 Fix: Encode unsupported repository debounce fingerprints
1 warning still open:
bin/fm-helm-watch.sh:34- Simplification: suppressing the separateanother Helm sync is already runningdiagnostic is not required by the stated goal to stop the unsupported-repository wake. Remove this filter unless the broader lock-contention wake behavior is intentionally in scope.bin/fm-test-run.sh --changed --exclude-family real-herdr-gated✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.