Symfony 8 support

[botris]

Hi thanks for the ongoing work on BazingaGeocoderBundle.

I saw that related compatibility work is already in progress (notably #368
), so I wanted to acknowledge that first 👍

I’m targeting Symfony 8 and wanted to ask:

• Is there a rough timeline for official Symfony 8 support?
• Are there known blockers?

Happy to help test, adjust composer constraints, or work on fixes if that’s useful. Just let me know what would be most helpful on your side.

Thanks again for maintaining the project

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[Chris53897]

Today i worked on #380 and #367
after that is merged, we can make a new PR to have a look how much work there is left for symfony 8 support.
support for "doctrine/doctrine-bundle" 3 needs to be added.

[Chris53897]

The main work is done.

• Add Changelog-Entries
• Decide for new major version, because of the removed providers which is a BC Break
• Add strong PHP types?
• Drop support for symfony 5.4 ?
• ...

@norkunas WDYT?

[norkunas]

Yeah, i already created the 5.x branch previously, so the master is now reserved for v6.

Types - of course.
I also am planning to add doctrine listener auto registration before release.

About changelog - it sucks to maintain it manually :)
I just use github notes generation for the new release and imho thats enough

[norkunas]

And yes, 5.4 is old and we don't need to support it

[Chris53897]

@norkunas Are there any open tasks before tagging a new version with symfony 8 support?

[botris]

my 2 cents, I used dev on Symfony 8 but got "You have requested a non-existent service "Willdurand\GeocoderBundle\Validator\Constraint\AddressValidator". That still seems an issue for an 8 tag

[Chris53897]

Did you use AddressValidator is usercode directly?
Or is the error just at loading the bundle?
This should be Bazinga\GeocoderBundle\Validator\Constraint\AddressValidator or not?

[botris]

when you clear cache / rebuild the container that was thrown. I don't use the validator anywhere

[Chris53897]

I did test it on a project of mine. smyfony/framework-bundle 7
I got the same error on composer update on the step symfony console cache:clear

After running symfony console cache:clear 1-2 more times it worked.
But i could not reproduce it with uninstall / install this bundle.

On a another project i just run this command without problems
symfony composer require willdurand/geocoder-bundle:dev-master

@botris Can you try if symfony console cache:clear does work for you as well.

[norkunas]

I have tried myself now to update to dev-master and it worked properly, cache was cleared after update without issues.

[norkunas]

@norkunas Are there any open tasks before tagging a new version with symfony 8 support?

well i think it'd be good to close #341
other than that i just need to gather all changes to write proper release notes

[norkunas]

released

[Chris53897]

thanks