Show resource type chips in search results - #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gbl_resourceType_smsearch filterWhy
Subject values are less normalized and can be lengthy, which makes result cards noisy. Resource Type values are more consistent and usually limited to one or two values, so they provide more useful scannable metadata.
User impact
Search results and bookmarked-result cards now show Resource Type and Theme chips beneath the description. Clicking a Resource Type chip opens a filtered search for that value.
Validation
npm test -- --run— 956 tests passednpm run build— passedgit diff --check— passedRepository-wide lint and format checks still report pre-existing failures in unrelated files.
Closes #335