refactor: name decided contract state explicitly - #23
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe storage type ABI now uses ChangesStorage type alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR clarifies decided-state names while preserving wire values and deprecated aliases, and explicitly sets contract views to the intended default. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
LatestFinalizedandLatestDecided1and2unchangedLatestFinal/LatestNonFinalas deprecated Rust/Python/serde aliasesLATEST_DECIDEDWhy
The old
LatestNonFinalname exposed the accepted-queue implementation and became misleading once finalized transactions moved out of that queue. The requested state view is the latest state-changing decided transaction: newest accepted effect first, otherwise the latest finalized effect.Compatibility
No ABI value changes. Existing source and serialized names remain valid aliases.
Dependency
Depends on genlayerlabs/genvm-manager#25 for the shared generator and nested-call enum aliases.
Validation
v0.3-devexecutor build passed through the updated manager umbrellaSummary by CodeRabbit
Updates
latest_finalizedandlatest_decidedfor clearer terminology.latest_finalandlatest_non_finalremain supported as deprecated aliases for compatibility.Tests