Skip to content

fix(browser): emit completion for unexpected renderer results - #16

Merged
acastellana merged 1 commit into
mainfrom
fix/browser-render-failed-event
Jul 15, 2026
Merged

fix(browser): emit completion for unexpected renderer results#16
acastellana merged 1 commit into
mainfrom
fix/browser-render-failed-event

Conversation

@acastellana

@acastellana acastellana commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • emit browser_done with render_failed for unexpected renderer return shapes
  • preserve the existing agent error reply
  • add standalone display-wire regression coverage

Verification

  • checks/run.sh (22 checks, all green)

Release target: browser@0.2.3, repo tag v0.1.19.

Summary by CodeRabbit

  • Bug Fixes

    • Unexpected rendering results now consistently report a rendering failure instead of leaving the browser in an incomplete state.
    • Dashboard completion events and error responses now stay synchronized for rendering failures.
  • Tests

    • Added coverage to verify consistent failure reporting for unexpected renderer responses.
  • Documentation

    • Added release notes for browser version 0.2.3.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a948cadf-d785-491c-9da0-9e504ec6b0cc

📥 Commits

Reviewing files that changed from the base of the PR and between 3605da3 and 2ed5132.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • checks/browser_compact_test.exs
  • packages/browser/browser.ex

📝 Walkthrough

Walkthrough

Unexpected renderer return values now produce the standard browser_done event with a render_failed verdict and the existing error reply. Tests cover this behavior, and the browser 0.2.3 changelog documents it.

Changes

Browser renderer failure signaling

Layer / File(s) Summary
Unexpected renderer handling
packages/browser/browser.ex, checks/browser_compact_test.exs, CHANGELOG.md
The fallback delivery path emits a browser_done event with render_failed before returning the render failure error. Tests add an unexpected-result renderer and verify both outputs; the changelog records the behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: emitting completion for unexpected renderer results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/browser-render-failed-event

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@acastellana
acastellana merged commit 12a7866 into main Jul 15, 2026
2 of 3 checks passed
@acastellana
acastellana deleted the fix/browser-render-failed-event branch July 15, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant