feat: port contract storage quota to v0.123-dev - #1729
Merged
MuncleUscles merged 2 commits intoAug 14, 2026
Conversation
* feat: cap per-contract daily snapshot storage Add an optional MAX_CONTRACT_SNAPSHOT_BYTES_PER_DAY admission check on eth_sendRawTransaction. Cost is 2x pg_column_size(current_state.data) (accepted + finalized slots) without hydrating JSONB. Redis meters the UTC-day total; the first write of the day is always allowed so a fat contract is not hard-locked. Unset env and Redis errors fail open. * fix: recover consensus after validator wipe/recreate Smoke deploys raced the mock-validator teardown: workers froze a 0-node snapshot, then release() blocked on an uncommitted rotation_count UPDATE so the claim never retried. Reload from the registry when the cached snapshot is empty, and commit reset_transaction_rotation_count like the other rotation writes. * fix: drop Rally mention from sandbox quota errors * fix: make contract storage quota atomic
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MuncleUscles
marked this pull request as ready for review
August 14, 2026 14:48
Member
Author
|
/run-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.123-devValidation
13 passed—tests/unit/test_contract_storage_quota.pyandtests/unit/test_validator_manager_snapshot.pygit diff --check origin/v0.123-dev...HEADpassed