Repository navigation
Post-0.9.0 cleanup: RPM spec equality, internal-helper export, docs - #13
Merged
Merged
Conversation
- BacnetReadAccessSpecification == and hashCode compared only properties.length, so two specifications for the same object requesting different properties compared equal and collided in a Set/Map. Compare the property list by content, and add a regression test. - Stop exporting the internal mapConcurrent fan-out helper from the public API; it was unintentionally re-exported through device_scanner.dart. - README: correct the stale claim that the server does not implement SubscribeCOVPropertyMultiple — it has as a target since 0.9.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3Woz4Bu11Eqhjsh6q3q5b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, independent cleanups surfaced by a post-0.9.0 package assessment. No native/C changes.
BacnetReadAccessSpecificationequality —==/hashCodecompared onlyproperties.length, so two specifications for the same object requesting different properties compared equal and collided in aSet/Map. They now compare the property list by content. Added a regression test.mapConcurrenthelper from the public API — it was unintentionally re-exported throughdevice_scanner.dart; it remains package-internal (still used bydevice_description.dart).Not included: the Dependabot submodule bump (bacnet-stack →
afcf114) was investigated and declined — that revision is a rebased/divergent master tip whose Notification Class changes (#1551 Priority-as-BACnetARRAY, #1553 dynamic NC) break the server's NC handling at runtime, for no benefit relevant to this package. Recommend closing that Dependabot PR rather than merging.Checklist
dart format,dart analyze --fatal-infosanddart testpasstest/models/rpm_models_test.dart; full unit suite green)CHANGELOG.md🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3Woz4Bu11Eqhjsh6q3q5b
Generated by Claude Code