This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Avoid extra to_vec for key copy#1160
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Signer::sign_digest API to accept slices (&[u8]) for both the digest and the private key instead of taking ownership of Vec<u8>. This change eliminates unnecessary cloning and allocations across multiple blockchain signing implementations (Algorand, Bitcoin, Cosmos, Tron, XRP, and Gemstone). In gemstone/src/signer/decode.rs, the use of std::mem::take on the decoded private key should be updated to use Zeroizing::into_inner (if the returned type is wrapped in Zeroizing) or simply returned directly to prevent compilation errors or redundant operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.