Skip to content

Add setImmediate and clearImmediate - #3

Merged
dashersw merged 3 commits into
mainfrom
fix/set-immediate
Oct 21, 2026
Merged

dashersw merged 3 commits into
mainfrom
fix/set-immediate

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

setImmediate was missing; the reactor gains a check-phase queue and the globals and node:timers an Immediate handle, ordered against ticks, microtasks and timers as in Node.

  • bc3389b Add a check-phase immediate queue to the reactor with _gea_node_immediate* intrinsics
  • 5184add Implement setImmediate and clearImmediate with an Immediate handle in global-timers and node:timers
  • b19461c Add scripts/test-set-immediate.mjs: node-vs-compiled ordering parity for immediates, ticks, microtasks and timers

Verification: node scripts/test-set-immediate.mjs → SET_IMMEDIATE_PARITY_OK:14.

Related

Independent of the other three runtime fixes (#2, #4, #5). Branch nest/base is main plus these four and is the base of #6 (Nest 1/4).

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aae50fed-f7cd-45cc-852b-e0549640a587
📥 Commits

Reviewing files that changed from the base of the PR and between 7337902 and b19461c.

⛔ Files ignored due to path filters: 2
  • runtime/node/generated/facades/timers.ts is excluded by !**/generated/**
  • runtime/node/generated/node24-compatibility.json is excluded by !**/generated/**
📒 Files selected for processing: 8
  • apps/nest-node-probe/correctness/set-immediate.ts
  • plugin/intrinsics.mjs
  • runtime/gea_node.cpp
  • runtime/node/global-timers.ts
  • runtime/node/node-globals.ts
  • runtime/node/timers.ts
  • scripts/test-set-immediate.mjs
  • tools/node-api/generate-surface.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Add Carrot credits or activate Agent usage billing to use Autofix

@puskuruk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@dashersw
dashersw merged commit 0e167f4 into main Oct 21, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants