Repository navigation
Add setImmediate and clearImmediate - #3
Merged
Merged
Conversation
…diate_* intrinsics
… global-timers and node:timers
…for immediates, ticks, microtasks and timers
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 19, 2026
puskuruk
marked this pull request as ready for review
October 19, 2026 03:19
|
Add Carrot credits or activate Agent usage billing to use Autofix |
Collaborator
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setImmediatewas missing; the reactor gains a check-phase queue and the globals andnode:timersanImmediatehandle, ordered against ticks, microtasks and timers as in Node.Verification:
node scripts/test-set-immediate.mjs→SET_IMMEDIATE_PARITY_OK:14.Related
Independent of the other three runtime fixes (#2, #4, #5). Branch
nest/baseismainplus these four and is the base of #6 (Nest 1/4).