Repository navigation
Raise the @geastack/compiler floor to ^1.0.43 - #10
Merged
Merged
Conversation
`apps/hono-hello` does not certify on 1.0.29, the floor until now: five slot-drift rows (`instanceof` narrowing chains in the `Request` and `Blob` constructors of `runtime/node/globals.ts`, and hono's reg-exp router), the same on main and on every open branch. 1.0.43, the current release, builds it and `scripts/test-hono.mjs` passes. The peer and dev ranges move together and the lock follows.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/hono-hellodoes not certify on@geastack/compiler1.0.29, the floor until now. The build stops at five slot-drift rows:instanceofnarrowing chains in theRequestconstructor (runtime/node/globals.tslines 820, 825, 835) and theBlobconstructor (line 1325), plus one in hono's reg-exp router. It is the same on main b60430e, on #4 and on the Nest stack, so it is the compiler version and not a runtime change. 1.0.43, the current release, builds it andscripts/test-hono.mjspasses 6/6.The peer and dev ranges move to
^1.0.43together and the lock follows. Nothing else in the repository states the floor (README and ARCHITECTURE mention 1.0.17 only as benchmark provenance).Verification
On this tip with the published 1.0.43 tarball (
GEA_COMPILER_DIRat a scratchnpm install @geastack/compiler@1.0.43): hono-hello builds and links, and all 26scripts/test-*.mjspass, includingtest-package,test-fastify-host-provenance,test-fastify-host-surfaces,test-hono,test-fs-stat(15),test-set-immediate(15),test-net-auto-select-family,test-http-overlapping-awaits.Related
scripts/test-dictionary-missing.mjsskips) waits on a release carrying Observe absence under typeof and ?? for index-signature reads compiler#14 and a later floor bump.