Skip to content

Document the examples checkout the test runner starts from - #74

Open
nejdetkadir wants to merge 1 commit into
geastack:mainfrom
nejdetkadir:docs/development-test-runner
Open

nejdetkadir wants to merge 1 commit into
geastack:mainfrom
nejdetkadir:docs/development-test-runner

Conversation

@nejdetkadir

Copy link
Copy Markdown
Contributor

Problem

Following docs/DEVELOPMENT.md as written does not run core's tests:

  • node test/test_gea_app_manifest.mjs fails with Cannot find module. The file is not in the repo or its history.
  • ./test/run-tests.sh from packages/core turns every run-gea-*-pipeline.sh into a SKIP that exits 0. test/native-test-common.sh compiles apps from the examples checkout the runner is started in, and its header gives the command.
  • Test Strategy points app manifest and launcher behavior at packages/core/test/test_gea_*.mjs. None of the eight files mentions either.
  • App Manifest Tools points at packages/core/tools, which does not exist.

Change

docs/DEVELOPMENT.md only:

  • Replace the two commands with the one from test/native-test-common.sh, run from an examples checkout.
  • Point launcher behavior at run-gea-app-launcher-pipeline.sh.
  • Point App Manifest Tools at src/manifest.mjs, src/build-config.mjs (validateBuildManifest) and src/apps/launcher-catalog.mjs in geastack/cli.

Tests

Documentation only; no code changed. The commands I used to check each statement, on macOS with Node 26.10.0:

$ cd packages/core && node test/test_gea_app_manifest.mjs
Error: Cannot find module '…/core/packages/core/test/test_gea_app_manifest.mjs'

$ bash test/run-gea-app-launcher-pipeline.sh; echo "exit=$?"
SKIP: run this from an app project (a directory with an apps/ folder, e.g. a checkout of geastack/examples); cwd is …/core/packages/core
exit=0

Notes for review

I could not get a full run of the documented command, so this PR documents only what the repo already states:

I left these out of the doc because I could not confirm a working setup for them. If you can tell me how the suite is meant to run end to end, I'll document it in a follow-up.

DEVELOPMENT.md ran node test/test_gea_app_manifest.mjs and
./test/run-tests.sh from packages/core. The manifest test does not
exist, and from packages/core every run-gea-*-pipeline.sh prints SKIP
and exits 0: native-test-common.sh compiles apps from the examples
checkout the runner is started in, and its header gives that command.

The Test Strategy entry pointed app manifest and launcher behavior at
test_gea_*.mjs, none of which tests either; the launcher has its own
pipeline. The helpers it placed under packages/core/tools live in
geastack/cli.
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 00a1d8ef-05f1-47f4-8c50-3bda784d8e7d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nejdetkadir

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant