Repository navigation
Document the examples checkout the test runner starts from - #74
Open
nejdetkadir wants to merge 1 commit into
Open
nejdetkadir wants to merge 1 commit into
nejdetkadir wants to merge 1 commit into
Conversation
DEVELOPMENT.md ran node test/test_gea_app_manifest.mjs and ./test/run-tests.sh from packages/core. The manifest test does not exist, and from packages/core every run-gea-*-pipeline.sh prints SKIP and exits 0: native-test-common.sh compiles apps from the examples checkout the runner is started in, and its header gives that command. The Test Strategy entry pointed app manifest and launcher behavior at test_gea_*.mjs, none of which tests either; the launcher has its own pipeline. The helpers it placed under packages/core/tools live in geastack/cli.
|
All contributors have signed the CLA. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Following
docs/DEVELOPMENT.mdas written does not run core's tests:node test/test_gea_app_manifest.mjsfails withCannot find module. The file is not in the repo or its history../test/run-tests.shfrompackages/coreturns everyrun-gea-*-pipeline.shinto aSKIPthat exits 0.test/native-test-common.shcompiles apps from theexamplescheckout the runner is started in, and its header gives the command.packages/core/test/test_gea_*.mjs. None of the eight files mentions either.packages/core/tools, which does not exist.Change
docs/DEVELOPMENT.mdonly:test/native-test-common.sh, run from anexamplescheckout.run-gea-app-launcher-pipeline.sh.src/manifest.mjs,src/build-config.mjs(validateBuildManifest) andsrc/apps/launcher-catalog.mjsin geastack/cli.Tests
Documentation only; no code changed. The commands I used to check each statement, on macOS with Node 26.10.0:
Notes for review
I could not get a full run of the documented command, so this PR documents only what the repo already states:
test_gea_vite_module_graph_assets.mjswithCannot find module '@geastack/core/package.json'. WithGEA_CORE_DIRandGEA_HOST_DIRset by hand, as Point the module-graph asset test's compiler at this checkout's Core #66 does, 109 steps ran beforerun-native-button-contract.shstopped onGEA_COMPILER_CLI.GEA_COMPILER_CLI,GEA_JSDOM_PACKAGE,GEA_TEST_RUNTIME_HEADER,GEA_CENSUS_REFERENCE_ENGINEandGEA_CENSUS_CANDIDATE_ENGINE. It reads thesimulator,linuxandapplecheckouts next to core. Therun-gea-companion-*.shtests build agea-companionapp that is not inexamples.I left these out of the doc because I could not confirm a working setup for them. If you can tell me how the suite is meant to run end to end, I'll document it in a follow-up.