Skip to content

chore: scrub adult-site domain from smoke-test workflows (ENG-1347) - #100

Open
jadoonf wants to merge 2 commits into
mainfrom
chore/fixture-scrub
Open

chore: scrub adult-site domain from smoke-test workflows (ENG-1347)#100
jadoonf wants to merge 2 commits into
mainfrom
chore/fixture-scrub

Conversation

@jadoonf

@jadoonf jadoonf commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the last adult-site domain from the repo before the Marketplace listing goes public (Linear ENG-1347).

  • The only hits in the whole repo (fixtures, tests, docs, examples, workflows — searched with a broad case-insensitive pattern list including hidden directories) were three curl https://xvideos.com probe steps in the PR-comment smoke-test workflows (.github/workflows/pr-comment-smoke-test-a-and-b.yaml ×2 jobs, pr-comment-smoke-test-c.yaml ×1).
  • Replaced with oastify.com (an Interactsh OOB-testing domain already on the control-plane's embedded malicious-domains blocklist), so the step still exercises the known-bad-egress detection path — the test semantics ("resolvable domain that triggers a detection") are preserved, unlike a documentation-reserved domain that would never resolve or connect.
  • Committed test fixtures (test/fixtures/profiles/*.json, goldens) and README/docs were already clean; the runtime-review-testbed repo scans clean too.

Test plan

  • rg -i --hidden for the adult-domain pattern list returns zero hits repo-wide
  • Smoke-test workflows are workflow_dispatch / label-gated — next run-smoke-tests run should show the oastify.com probe flagged as before

Linear: ENG-1347


Open in Devin Review

Replace the xvideos.com curl probes in the PR-comment smoke tests with
oastify.com, which sits on the embedded malicious-domains blocklist, so
the steps still exercise known-bad egress detection without an
adult-site domain in the public repo before Marketplace visibility.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@jadoonf
jadoonf enabled auto-merge (squash) July 8, 2026 20:17
@garnet-runtime-review

garnet-runtime-review Bot commented Jul 23, 2026

Copy link
Copy Markdown

See what ran — every outbound connection and its process lineage.

Runtime behavior for jobs triggered by commit 060ac47 · recorded at the kernel · 2026-07-23 17:06:16 UTC

💡 Reading this review

Each job fold connects recorded process lineage to recorded outbound destinations. Bold lineage is attributed to a GitHub step below Runner.Worker; italic lineage is runner scaffolding. Typography only shows attribution context.

Runner.Worker
└─ bash
   └─ curl
      └─ → example.com

1 job recorded on this commit

CI / build-and-verify
build-and-verify · job
└─ systemd
   └─ hosted-compute-agent
      ├─ Runner.Listener
      │  └─ Runner.Worker
      │     ├─ bash
      │     │  └─ node
      │     │     ├─ → registry.npmjs.org
      │     │     └─ → localhost (dns resolver)
      │     └─ node
      │        ├─ → localhost (dns resolver)
      │        └─ → api.github.com
      └─ sudo
         └─ provjobd3490110920
            └─ → localhost (dns resolver)

View Run Profile in Garnet ↗

@nicolasparada nicolasparada added the run-smoke-tests Enable running smoke tests on CI label Jul 23, 2026
@garnet-runtime-review-dev

garnet-runtime-review-dev Bot commented Jul 23, 2026

Copy link
Copy Markdown

See what ran — every process your jobs executed, and where they connected

commit 060ac47 · recorded at the kernel · as of Jul 23 2026, 5:08 PM UTC

💡 how to read this

Each fold below is one CI job. Its heading is workflow / job ↗ — the job name links to its GitHub Actions run — followed by what Garnet's kernel-level sensor counted.

Open a fold and read the tree top-down — exactly as it renders below:

Runner.Worker                     ← italic = runner scaffolding
   └─ bash
      └─ curl                     ← bold = a process the job ran
         ├─ → httpbin.org         ← a place it reached
         └─ → localhost (dns resolver)  ← a note = expected plumbing

Italics are the runner's own scaffolding, not your code · a bare IP means no domain was observed for it · ×N = the same connection, N times · localhost lookups render in the tree but aren't counted as destinations · a job that reached a destination no other job reached starts open — a glance, not a verdict. For the full record, open View Run Profile in Garnet ↗.

3 jobs across 2 workflows recorded on this commit

PR Comment Smoke Test A and B / smoke-a8 processes · reached 13 destinations
smoke-a · job
└─ systemd
   └─ hosted-compute-agent
      ├─ Runner.Listener
      │  └─ Runner.Worker
      │     └─ bash
      │        └─ curl
      │           ├─ → chainstack.com
      │           ├─ → localhost (dns resolver)
      │           ├─ → example.org
      │           ├─ → browsermine.com
      │           ├─ → 172.86.88.188
      │           ├─ → webhook.site
      │           ├─ → 198.51.100.10
      │           ├─ → 198.51.100.11
      │           ├─ → 198.51.100.5
      │           ├─ → 203.0.113.1
      │           ├─ → 203.0.113.2
      │           └─ → PublicInteractionNLB-3bddf5ff6abb91b6.elb
      ├─ sudo
      │  └─ provjobd838609862
      │     └─ → 140.82.113.24 (github infra)
      └─ → 140.82.112.24 (github infra)

View Run Profile in Garnet ↗

PR Comment Smoke Test A and B / smoke-b8 processes · reached 11 destinations
smoke-b · job
└─ systemd
   └─ hosted-compute-agent
      ├─ Runner.Listener
      │  └─ Runner.Worker
      │     └─ bash
      │        └─ curl
      │           ├─ → chainstack.com
      │           ├─ → localhost (dns resolver)
      │           ├─ → pastebin.com
      │           ├─ → browsermine.com
      │           ├─ → 172.86.88.188
      │           ├─ → webhook.site
      │           ├─ → 198.51.100.10
      │           ├─ → 198.51.100.11
      │           ├─ → 198.51.100.5
      │           ├─ → 203.0.113.1
      │           ├─ → 203.0.113.2
      │           └─ → oastify.com
      └─ sudo
         └─ provjobd867460546
            └─ → localhost (dns resolver)

View Run Profile in Garnet ↗

PR Comment Smoke Test C / smoke-c8 processes · reached 12 destinations
smoke-c · job
└─ systemd
   └─ hosted-compute-agent
      ├─ Runner.Listener
      │  └─ Runner.Worker
      │     └─ bash
      │        └─ curl
      │           ├─ → chainstack.com
      │           ├─ → example.org
      │           ├─ → localhost (dns resolver)
      │           ├─ → pastebin.com
      │           ├─ → browsermine.com
      │           ├─ → 172.86.88.188
      │           ├─ → webhook.site
      │           ├─ → 198.51.100.10
      │           ├─ → 198.51.100.11
      │           ├─ → 198.51.100.5
      │           ├─ → 203.0.113.1
      │           ├─ → 203.0.113.2
      │           └─ → oastify.com
      └─ sudo
         └─ provjobd367113409
            └─ → localhost (dns resolver)

View Run Profile in Garnet ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-smoke-tests Enable running smoke tests on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants