Avoid some uses of IdGroup#6343
Conversation
We should keep uses of smallgrp/primgrp/transgrp to a minimum
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6343 +/- ##
==========================================
+ Coverage 78.56% 78.60% +0.03%
==========================================
Files 684 684
Lines 292844 292699 -145
Branches 8657 8660 +3
==========================================
+ Hits 230070 230073 +3
+ Misses 60964 60814 -150
- Partials 1810 1812 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is this a good idea? I think it is very useful to talk about (the isomorphism type of) a group in terms of some identifier. |
|
I agree that we shouldn't just replace all uses of |
|
@ThomasBreuer OK to merge this? I sympathize with the wish to have some "rules" somewhere on this, but I don't know where to put those; and honestly, there are countless more such things were some people know to avoid certain things (e.g. immediate methods) but it is not codified anywhere. And here I am not even sure what the "rule" should be: I don't mean to forbid Anyway, I also filed #6346 |
We should keep uses of smallgrp/primgrp/transgrp to a minimum (see #2434).
Also, the uses here directly affects some package test suites, as revealed by my experiments at gap-system/PackageDistro#1183