Fix MinimalGeneratingSet for pc groups which sometimes returned incorrect (non-minimal) results#6340
Open
Fix MinimalGeneratingSet for pc groups which sometimes returned incorrect (non-minimal) results#6340
MinimalGeneratingSet for pc groups which sometimes returned incorrect (non-minimal) results#6340Conversation
It sometimes produced incorrect results, where at least one generator was simply redundant. Revisit the pc-group candidates when a layer contracts. This drops generators that were only needed earlier. Later layer adjustments can change the induced pcgs. AI-assisted by Codex for investigation, testing, and implementation. Co-authored-by: Codex <codex@openai.com>
fingolfin
added
kind: bug
Member
Author
|
@hulpke @ThomasBreuer @ChrisJefferson @james-d-mitchell any thoughts on this? |
hulpke
approved these changes
Apr 29, 2026
Contributor
hulpke
left a comment
hulpke
left a comment
There was a problem hiding this comment.
This certainly resolves one problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It sometimes produced incorrect results, where at least one generator was simply redundant.
Revisit the pc-group candidates when a layer contracts. This drops generators that were only needed earlier. Later layer adjustments can change the induced pcgs.
AI-assisted by Codex for investigation, testing, and implementation.
Fixes #5771.