Skip to content

Add 'dot2tex' under ExternalConditions#36

Merged
ZachNewbery merged 4 commits intomainfrom
35-externalconditions-should-include-dot2tex
Apr 25, 2026
Merged

Add 'dot2tex' under ExternalConditions#36
ZachNewbery merged 4 commits intomainfrom
35-externalconditions-should-include-dot2tex

Conversation

@ZachNewbery
Copy link
Copy Markdown
Collaborator

@ZachNewbery ZachNewbery commented Sep 30, 2025

Why:

Closes #35

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding 'dot2tex' to ExternalConditions so that users are aware of it being required for digraph conversion.

Additionally, fixing CI badge link in README to conform to new format.

Check off the following:

  • I have added the necessary functions to implement my fix in a structured, readable way.
  • I have documented my added code to the codebase, added new directories to makedoc.g and new chapters/sections to order_info.g.
  • I have tested my additions, and included the tests within the tst directory.
  • I have summarised any large features as bullet points in CHANGELOG.md.

@ZachNewbery ZachNewbery linked an issue Sep 30, 2025 that may be closed by this pull request
@ZachNewbery ZachNewbery self-assigned this Sep 30, 2025
Comment thread PackageInfo.g Outdated
Co-authored-by: Max Horn <max@quendi.de>
Signed-off-by: Zach Newbery <47321182+ZachNewbery@users.noreply.github.com>
Signed-off-by: Zach Newbery <47321182+ZachNewbery@users.noreply.github.com>
Copy link
Copy Markdown
Member

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I am not sure why CI badge needs to be updated in the same commit PR.

@ZachNewbery
Copy link
Copy Markdown
Collaborator Author

Looks good, although I am not sure why CI badge needs to be updated in the same commit PR.

I noticed it was broken due to some changes to the URL formatting, didn't feel it was significant enough for a separate PR. I'll mention it in the description though for brevity!

@ZachNewbery ZachNewbery merged commit cceefaf into main Apr 25, 2026
6 checks passed
@ZachNewbery ZachNewbery deleted the 35-externalconditions-should-include-dot2tex branch April 25, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExternalConditions should include dot2tex

3 participants