Refactor PrimitiveIdentification - #101
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 99.35% 99.61% +0.26%
==========================================
Files 52 52
Lines 44830 44793 -37
==========================================
+ Hits 44541 44622 +81
+ Misses 289 171 -118
🚀 New features to boost your workflow:
|
PrimeDivisors returns an immutable list, so Remove on it failed, and the Sylow order test read `ag`, which is only assigned inside the helper closures. Both stopped identification with an error, the first already for PrimitiveGroup(10,4). No test noticed, because primid.tst asks library groups for a number they already carry. Add a round trip over degree 2 to 100 that identifies groups rebuilt from conjugated generators. Assisted-by: Claude Code (Fable 5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.