Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 50.30% 51.74% +1.43%
==========================================
Files 38 38
Lines 9317 9317
Branches 789 789
==========================================
+ Hits 4687 4821 +134
+ Misses 4595 4461 -134
Partials 35 35
🚀 New features to boost your workflow:
|
GAP 4.17 makes PreImagesRepresentative test membership in the image and adds an unchecked PreImagesRepresentativeNC. For maps into sphere groups with 6 generators the test runs a coset enumeration that overflows; for EpimorphismToOut it returns fail, since the randomised images of the generators need not span the range. SubFRMachine, marked sphere lifting, DistanceMarkedSpheres and AutomorphismSphereMachine broke, and chapter-9-b.tst failed twice. Call the NC variant at these sites. The elements are generators of the range of an isomorphism or epimorphism, except in SubFRMachine, which needs fail outside the image; the NC method returns fail there, as the unchecked method of GAP 4.16 did. Assisted-by: Claude Code (Opus 5)
fingolfin
force-pushed
the
mh/preimages-nc
branch
from
September 23, 2026 10:07
fab3e07 to
b02016b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAP 4.17 makes PreImagesRepresentative test membership in the image and adds an unchecked PreImagesRepresentativeNC. For maps into sphere groups with 6 generators the test runs a coset enumeration that overflows; for EpimorphismToOut it returns fail, since the randomised images of the generators need not span the range. SubFRMachine, marked sphere lifting, DistanceMarkedSpheres and
AutomorphismSphereMachine broke, and chapter-9-b.tst failed twice.
Call the NC variant at these sites. The elements are generators of the range of an isomorphism or epimorphism, except in SubFRMachine, which needs fail outside the image; the NC method returns fail there, as the unchecked method of GAP 4.16 did.
Assisted-by: Claude Code (Opus 5)
CC @ThomasBreuer @cdwensley