Conversation
GAP 4.17 splits PreImagesSet and PreImagesRepresentative into checked operations and unchecked NC variants, and its library calls only the NC variants. Install the geometry morphism method for PreImagesSetNC, so that library calls find it, and keep a PreImagesSet method delegating to it: the generic checked method fails its IsSubset test on geometry morphisms. Call the NC variants internally where the argument is known to lie in the image (stabiliser generators under action homomorphisms, the BLT-set under the duality), avoiding the range and image membership tests. For GAP < 4.17, init.g binds the NC names to the checked operations. Assisted-by: Claude Code (Opus 5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 53.25% 53.55% +0.30%
==========================================
Files 34 34
Lines 17041 17059 +18
==========================================
+ Hits 9075 9136 +61
+ Misses 7966 7923 -43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
force-pushed
the
mh/preimages-nc
branch
from
September 23, 2026 10:07
93188ce to
089f0bd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAP 4.17 splits PreImagesSet and PreImagesRepresentative into checked operations and unchecked NC variants, and its library calls only the NC variants. Install the geometry morphism method for PreImagesSetNC, so that library calls find it, and keep a PreImagesSet method delegating to it: the generic checked method fails its IsSubset test on geometry morphisms.
Call the NC variants internally where the argument is known to lie in the image (stabiliser generators under action homomorphisms, the BLT-set under the duality), avoiding the range and image membership tests.
For GAP < 4.17, init.g binds the NC names to the checked operations.
Assisted-by: Claude Code (Opus 5)
CC @ThomasBreuer @cdwensley