First version using only bash#1
Conversation
| run: | | ||
| sudo apt-get install --no-install-recommends texlive-latex-base texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended | ||
| - name: "Run tests" | ||
| run: sudo apt install -y libarchive-tools # bsdtar |
There was a problem hiding this comment.
So why exactly do we need bsdtar?
There was a problem hiding this comment.
Good that you asked... made me realise I forgot the --strip-components option when extracting.
bsdtar isn't absolutely necessary, but it makes things a lot easier. If using GNU tar we can't use that to extract .zip archives, so we'd have to use unzip. But that doesn't support --strip-components, so we have to manually move files up one level. And on Windows/Cygwin we have to ensure we're working with Cygwin versions of tar and unzip instead of Windows ones. It's a mess, really.
| } | ||
|
|
||
| # Get archive URL | ||
| get_archive_url() { |
There was a problem hiding this comment.
This is turning into a quite complex shell script.
I don't mind, but next time, perhaps think about using e.g. Python instead? It has fewer warts and probably more people can help debug it ;-)
There was a problem hiding this comment.
Yeah... in hindsight that would've been better. Really don't have the time (and energy 😪 ) to rewrite it right now, though.
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Seems fine to me, merge if you will
|
Just need to swap the cygwin action back to the gap-actions repo once the latest commit is tagged (on phone so can't do this myself right now), then this one can be merged :) |
2 participants
I gave up on using
PackageManager, so this only usesbash(and GAP).The idea is to install the packages under
$GAPROOT/pkg, and to notbuild them here. The building can then be done by the
build-pkgaction,which seems appropriate, and I don't think it's a good idea to spread package
building over multiple actions.
For this to work properly on Windows/Cygwin, we do need to install
jqandbsdtar- see gap-actions/setup-cygwin#20.