Fix void out with overworld spawn out of a grotto - #853
Merged
Merged
Conversation
Kewlan
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the latest crash reported on Discord.
When coming out of a grotto, the game does not set the void out respawn point. Normally the Randomizer already handles it, so that when the grotto entrance is randomized, the respawn point is updated anyway.
But when loading a save file, the game sets the entrance index stored in the respawn data to -1, after the Randomizer code writes it: https://github.com/zeldaret/oot/blob/cbe814b25455f14a343a7457c4b1c92af40ede6a/src/overlays/gamestates/ovl_file_choose/z_file_choose.c#L1888
So if you load a file, spawn out of a grotto and then void out, the game will either go back to the Title Screen if the respawn point's room index is 0, or crash otherwise.
The easy fix implemented here is to reset the respawn point's entrance index after the file load completes.