FIX typo that caused webgl shaders not to be set#620
Merged
mvdoc merged 1 commit intogallantlab:mainfrom Apr 18, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the property name magFilter, changing it from magfilter to the correct camelCase magFilter in two locations within cortex/webgl/resources/js/dataset.js. I have no feedback to provide as there were no review comments.
Contributor
|
seem reasonable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When displaying long movie volumes, voxels can sometimes appear to "drop out". Only the voxel boundaries would be rendered, and the rest of the surface would remain blank. This seemed to only happen after the first few frames of the video (between 8 and 30 with Firefox my laptop, low 100s for the headless viewer). It is not the effect of rendering partially loaded volumes -- this happens even after letting the browser "rest" for several minutes before interacting with the viewer.
Solution
The typo meant that
magFilterwas not set (onlyminFilterwas) for all volumes loaded some time after the page was loaded.Before fixing the typo:
After (expected):
