Split traffic.go into focused files - #21
Merged
Merged
Conversation
traffic.go carried CLI definition, pipeline, normalization, filtering, rendering, catalog, geo math, and shared feed helpers. Now: traffic.go (types, command, ODH pipeline), traffic_normalize/filter/render/catalog/geo/feed.go, text.go already holds the shared text helpers. All 61 functions moved verbatim; verified by scripted diff against the pre-split file. Removes the firstNonEmptyString near-duplicate in diagnostics.go and fixes a 7-cell markdown separator under the 6-column traffic table. Closes #20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20. Pure move, no JSON contract change: traffic.go keeps types, command definition, and the ODH pipeline; normalization, filtering, rendering, catalog, geo math, and shared feed helpers move to traffic_{normalize,filter,render,catalog,geo,feed}.go. All 61 functions verified verbatim against the pre-split file by scripted diff. Also removes the firstNonEmptyString near-duplicate and fixes a 7-cell markdown separator under the 6-column table. gofmt, vet, full suite green.