Repository navigation
Galette 1.3.0 and improvements - #46
Merged
Merged
Conversation
bin/console sits next to the galette directory in release archives and was left out; it finds galette/ from its own location.
The CMD was handed to the entrypoint, which ignored it, and cron cannot start as www-data anyway. supercronic now runs the reminders and the mailing queue drainer added in 1.3.0 from the entrypoint, without root.
tidy is not used by Galette.
Downloads no longer remain in image layers, and build steps that did nothing are gone.
documents, exports and imports were not mounted, so their content was lost when the container was recreated.
grasdk
reviewed
Oct 5, 2026
grasdk
left a comment
grasdk
left a comment
Collaborator
There was a problem hiding this comment.
Hey @trasher
I see you put a lot of work into this. I don't have much time, but from a brief glance I think what you have done looks sound and you have optimized some of the scripting in the Dockerfile (and added the scheduled jobs).
From my point of view, this looks safe. If you have already built the container and tested that it works, I see no reason not to merge this.
Member
Author
|
Hello @grasdk; thanks for the review :) Yes, I built the container, install and add seed-data (from cli), and browse instance: everything went fine :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to Galette 1.3.0 - several improvements (ship
bin/console, fix crontasks, ...).Can be reviewed per commit.