Skip to content

Make PO extraction independent of local environment - #90

Merged
gagnieray merged 1 commit into
developfrom
fix/stable-po-generation
Oct 7, 2026
Merged

gagnieray merged 1 commit into
developfrom
fix/stable-po-generation

Conversation

@trasher

@trasher trasher commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

The generated *_en_US.po header and the POT entry order depended on the contributor's machine:

  • msginit --locale=en_US.utf8 takes the charset from that locale; when it is not installed, it falls back to charset=ASCII (seen in Change success message plugin-helloasso#70). The POT is now forced to UTF-8 before msginit.
  • source files were passed to xgettext in find order, which depends on the filesystem; they are now sorted with make's $(sort …), which is locale independent.

Only lang/Makefile changes. The next extraction will reorder the POT once.

@trasher
trasher requested a review from gagnieray October 7, 2026 19:46
@gagnieray
gagnieray merged commit 6cfb07d into develop Oct 7, 2026
12 checks passed
@gagnieray
gagnieray deleted the fix/stable-po-generation branch October 7, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants