Repository navigation
Fix Select Base UI parity regressions - #901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness: Codex
Agent: none
Model: gpt-6-astra
Task statements
Fix the Select behaviour differences confirmed by Base UI parity reproductions, with regression tests and updated reference documentation. (Working-directory and workflow instructions omitted.)
Open this first PR for the six confirmed fixes while the complete Base UI Select inventory continues in a follow-up PR. (Working-directory and workflow instructions omitted.)
This change brings Select group semantics, valueless item highlighting, keyboard focus and opening navigation, ItemText context errors, and selected-item removal behaviour in line with Base UI 1.8.0.
The wider Base UI Select inventory is still in progress. A follow-up PR will account for all 288 source test rows, report the final counts, and update tracking issue #841.
Verification
origin/main, the selected regression run reported6 failed, 2 passed, 84 skipped.select-parity.test.tsxpasses all 93 tests, including the six repaired behaviours.Closes #872
Closes #895
Closes #896
Closes #897
Closes #898
Closes #900