Repository navigation
Report virtual-list range after data changes - #894
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness: Codex
Agent: none
Model: gpt-6-astra
Task statements
What changed
<virtual-list>now reports a changed visible range after list data or layout updates, including when a smalleritemCountclamps the scroll position. Repeated updates that leave the range unchanged do not emit duplicate callbacks. The renderer preserves the last reported range when it replaces list state, then checks the laid-out range after the update. The test renderer delivers native events from a committed render before returning, matching the live renderer.Closes #882.
Surface audit
windowStart, row-height estimates and viewport height.scrollTopand scroll metrics report the clamped position and content extent. GPUI's scrollbar offset and maximum derive from that same list state.<virtual-list>does not exposeonScroll; ordinary overflow containers still reportonScrollwhen a content update clamps them.Validation
Part 12after shrinking from 106 rows to 12, andPart 1was missing. The regression now reports{ startIndex: 0, endIndex: 12 }and the windowed consumer returns toPart 1.@gpuix/reactand@gpuix/native: the bare-list range test and the data-table first-row-after-shrink test both pass.