chore(release): 1.2.2 - #26
Merged
Merged
Conversation
No source changes since 1.2.1. What ships differs anyway, because dependabot bumped vite from ^7.3.1 to ^8.2.1 in #22 and vite is what builds dist. Comparing the published 1.2.1 tarball against a fresh build: dist/index.mjs 101064 -> 94573 (-6491) dist/index.cjs 66917 -> 68068 (+1151) dist/styles.css unchanged type declarations unchanged So this is a rebuilt bundle rather than an empty version bump. It also gives 1.2.2 a valid provenance attestation. Stripping the Co-authored-by trailers rewrote main, so the attestation published for 1.2.1 names commit 005f7ca, which no longer exists in history. That cannot be re-signed, but once 1.2.2 is latest, the version people install has a provenance chain that verifies again. Merging this exercises three things that have never actually run: the registry-based publish gate, the bumped actions including action-gh-release@v3, and auto-publish on push to main without a dispatch. Verified locally with vite 8.2.1: npm ci, typecheck, lint, format:check, test:coverage (354 tests, 19 files), build, and build:storybook all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does releasing 1.2.2 help?
Partly — worth being precise about what it does and doesn't fix.
It does not repair 1.2.1. Stripping the
Co-authored-bytrailers rewrotemain, so the provenance attestation published for 1.2.1 names commit005f7cac, which no longer exists in history. A published version can't be re-signed. That attestation is permanently broken.It does restore a verifiable
latest. Once 1.2.2 is out, the version people actually install has a provenance chain that resolves against real history. The broken one stops being the default.It also exercises three things that have never run. Worth having a low-stakes release do it rather than a release you care about:
action-gh-release@v3main, with no dispatchThis isn't an empty version bump
No source changes since 1.2.1 — nothing under
src/moved, andfilesis just["dist"]. But dependabot bumped vite^7.3.1→^8.2.1in #22, and vite is what buildsdist. Diffing the published 1.2.1 tarball against a fresh build:dist/index.mjsdist/index.cjsdist/styles.cssOnly the two bundles and their sourcemaps differ. So consumers do get a genuinely rebuilt artifact, not just a new version number.
Worth a look before merging:
index.mjsdropping 6.5 kB whileindex.cjsgrows 1.2 kB is a bigger swing than a patch release usually implies. It's vite 8 changing its output, not a source change — but if you'd rather sanity-check the ESM bundle in a consumer before this goes out, that's a reasonable call.Verification
Full CI step list locally, against vite 8.2.1:
npm citypechecklintformat:checktest:coveragebuildbuild:storybookWhat happens on merge
Unlike every recent release, no dispatch needed. The push to
mainruns the gate, which asks the registry, gets a 404 for 1.2.2, and publishes. Expect a deployment to theNPMenvironment and av1.2.2release.If the publish fails for any reason, the new gate means the next push retries it — no stranded version, no burnt number. That's the property the old git-diff gate lacked.