Repository navigation
Polls follow-up: View votes window and vote percentages - #472
Merged
Merged
Conversation
The poll window gets a View votes button (Alt+V) that lists "person: option" for every vote, and the option lists show their percentage of the votes in the item text. Romanian votes no longer need the 20+ "de" agreement. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHFmZNcEwFvxPVKgfFYLgg
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHFmZNcEwFvxPVKgfFYLgg
…nnot Measured on a group poll: the vote's sender is the voter's @lid Wid, and ContactCollection has a name or pushname for each, including non-contacts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHFmZNcEwFvxPVKgfFYLgg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: opening a poll showed each option's vote count but not who voted, and the check-box lists showed counts only (the progress bars are not always read by NVDA). In Romanian, "20 voturi" was grammatically wrong.
After: the poll window has a View votes button (Alt+V) that opens a list of "person: option" lines, first row focused and selected; the people come from WhatsApp Web and are shown by name. Option lists (poll window and inline Tab list) now read "name, N votes (P%)". Romanian uses "voturi: N". The Vote button's mnemonic moved off V to free Alt+V.
How: new
readPollVotersinpollRuntime.tsand/poll-votersroute (on demand, only sender ids and option ids leave the page),fetch_poll_votersinpoll_sending.py, purevoter_rowsand a percent-awareoption_labelincore/polls.py,PollVotersDialog, strings in all 7 locales and changelogs.Needs a live check: the vote's sender property name in WhatsApp Web (
sender,senderUserJidorfromare tried).🤖 Generated with Claude Code
https://claude.ai/code/session_01PHFmZNcEwFvxPVKgfFYLgg
Generated by Claude Code