fix: remove dept display_name where api does not return it#789
Open
fix: remove dept display_name where api does not return it#789
Conversation
…s not return display_name - treating actual api as soruce of truth
muleyashutosh
approved these changes
Apr 30, 2026
Contributor
muleyashutosh
left a comment
muleyashutosh
left a comment
There was a problem hiding this comment.
have rubberstamped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref - https://fylein.slack.com/archives/C019TV6AZDH/p1777043267971699
TLDR: API spec mentions display_name in the nested departments object for GET employees, but we don't actually have display_name in employees_rot.department in the db. Same issue affects multiple APIs.
Clickup
app.clickup.com