Skip to content

procd: fix coldplug device-node race - #144

Merged
fwerkor merged 1 commit into
sync/openwrt-main-2026-10from
fix/procd-coldplug-devnodes
Oct 12, 2026
Merged

fwerkor merged 1 commit into
sync/openwrt-main-2026-10from
fix/procd-coldplug-devnodes

Conversation

@fwerkor

@fwerkor fwerkor commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Fix the procd coldplug device-node race on top of #145.

#145 already brings CapOS to OpenWrt procd 6a22d396 (2026-10-07 package update), so this PR now contains only the downstream coldplug fix that is not yet in upstream procd.

Fix:

  • synchronously recreate device nodes already present in sysfs after coldplug replaces /dev
  • keep hotplug authoritative for final device permissions by applying the requested mode when mknod returns EEXIST, then applying the configured group
  • bump PKG_RELEASE to 2

The source patch is generated directly from openwrt/procd draft PR #53 and applies cleanly to procd 6a22d396.

Validation:

  • git apply --check against procd 6a22d396
  • package-level changes pass git diff --check when patch-file context is excluded
  • upstream source commit carries Signed-off-by

Merge #145 first; this PR is intentionally based on the #145 branch.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T06:17:10.038302Z 4419f1d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
capos-snap 4419f1d Oct 09 2026, 06:15 AM

@fwerkor
fwerkor force-pushed the fix/procd-coldplug-devnodes branch from 726da43 to 1663c0d Compare October 9, 2026 04:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 726da43417

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package/system/procd/patches/100-coldplug-recreate-device-nodes.patch Outdated
@fwerkor
fwerkor force-pushed the fix/procd-coldplug-devnodes branch 2 times, most recently from 7b8f98a to ce81a4c Compare October 9, 2026 05:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce81a4c7b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fwerkor
fwerkor force-pushed the fix/procd-coldplug-devnodes branch from ce81a4c to ffe950b Compare October 9, 2026 05:57
@fwerkor
fwerkor changed the base branch from main to sync/openwrt-main-2026-10 October 9, 2026 05:57
@fwerkor
fwerkor force-pushed the fix/procd-coldplug-devnodes branch from ffe950b to 4419f1d Compare October 9, 2026 06:13
@fwerkor
fwerkor merged commit f4c793a into sync/openwrt-main-2026-10 Oct 12, 2026
4 checks passed
@fwerkor
fwerkor deleted the fix/procd-coldplug-devnodes branch October 12, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant