Update section.go - #3
Conversation
Add a check for false on private indicator: private_indicator – This is a 1-bit flag that shall be set to 0.
added a check on protocol version protocol_version: @ present, this attribute shall be set to 0.
futzu
left a comment
futzu
left a comment
There was a problem hiding this comment.
futzu/threefive#88 is an example of what I'm talking about with people using custom identifiers.
| infosec.Private = bd.asFlag() | ||
| if infosec.Private { | ||
| return false | ||
| } |
There was a problem hiding this comment.
You are correct, as far as the specification goes, but this gets us nothing, I've never seen this value used, and that's why Intentionally don't check it.
futzu
left a comment
futzu
left a comment
There was a problem hiding this comment.
How about instead of returning false, print a warning message to stderr.
futzu
left a comment
futzu
left a comment
There was a problem hiding this comment.
How about instead of returning false, print a warning message to stderr.
|
helloooooo |
|
Agree let's do it as warning |
|
Are you going to give me an update with the warnings? |
2 participants
Add a check for false on private indicator:
private_indicator – This is a 1-bit flag that shall be set to 0.