Fix UnboundLocalError in Prompt._handle_error on 400 responses - #29
Open
argjendhaxhiu wants to merge 1 commit into
Open
argjendhaxhiu wants to merge 1 commit into
argjendhaxhiu wants to merge 1 commit into
Conversation
detail was only assigned inside the try block, so if response.json() failed it stayed unbound while still being referenced in every branch below (TemplateAlreadyExists, the "No version found for label" check, and the final SDKException). This masked the real API error with an UnboundLocalError instead of a useful message. Initialize detail = None up front and guard each .get() call so it fails safely instead. Reproduced live via Prompt.get_template_by_name() on a real 400 response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 400 response whose body fails response.json() leaves detail unbound, so it masks the real API error with an UnboundLocalError instead. Hit this live calling Prompt.get_template_by_name(). Fix initializes detail = None up front and guards the later .get() calls.