Skip to content

chore: add CI, PHPStan level max and a self-check - #6

Merged
sebastienfontaine merged 2 commits into
mainfrom
feature/ci-phpstan
Oct 19, 2026
Merged

sebastienfontaine merged 2 commits into
mainfrom
feature/ci-phpstan

Conversation

@sebastienfontaine

Copy link
Copy Markdown
Contributor

Stacked on #5. This PR only contains the CI and PHPStan commits.

What

  • GitHub Actions: tests on PHP 8.1 to 8.4, PHPStan, and php-deps checking itself (--check --format=github).
  • PHPStan level max on src and tests, no baseline and no ignores. The class data and graph shapes are declared once as type aliases (ClassData, Edge, Graph, MinimalGraph...) and imported where used.
  • Config values from php-deps.php are validated with clear errors instead of being cast blindly.
  • php-deps.php at the repo root: the core analysis depends on nothing, Metrics only on the core, Architecture on core and metrics, and no class cycles.
  • composer test, composer analyse.

The workflow runs on every push and pull request; it already passes on this branch.

@sebastienfontaine sebastienfontaine changed the title Add CI, PHPStan level max and a self-check chore: add CI, PHPStan level max and a self-check Oct 19, 2026
@sebastienfontaine
sebastienfontaine force-pushed the feature/viewer-improvements branch from 50b3b29 to 94793ed Compare October 19, 2026 15:06
sebastienfontaine added 2 commits October 19, 2026 17:06
- GitHub Actions: tests on PHP 8.1 to 8.4, PHPStan, php-deps --check on itself
- PHPStan level max on src and tests, no baseline: class data and graph
  shapes declared once as type aliases (ClassData, Edge, Graph...)
- Config values validated with clear errors instead of being cast blindly
- php-deps.php enforces the package's own layers and forbids class cycles
@sebastienfontaine
sebastienfontaine changed the base branch from feature/viewer-improvements to main October 19, 2026 15:06
@sebastienfontaine
sebastienfontaine merged commit 85a0031 into main Oct 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant