fix(ci): scope workflow write permissions to job level and enforce SonarCloud quality gate wait

.github/workflows/javadoc-pages.yml

@@ -12,8 +12,6 @@ on:
 
 permissions:
   contents: read
-  pages: write
-  id-token: write
 
 concurrency:
   group: "pages"
@@ -50,7 +48,7 @@ jobs:
           fi
           mvn package -P release -DskipTests --batch-mode
           mkdir -p apidocs-site
-          JAR_FILE=$(ls tsql-scriptdom-core/target/*-javadoc.jar | head -n 1)
+          JAR_FILE=$(ls ./tsql-scriptdom-core/target/*-javadoc.jar | head -n 1)
           unzip -q "${JAR_FILE}" -d apidocs-site
 
       - name: Configure GitHub Pages
@@ -65,6 +63,9 @@ jobs:
     name: Deploy to GitHub Pages
     needs: build
     runs-on: ubuntu-latest
+    permissions:
+      pages: write
+      id-token: write
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}

.github/workflows/release.yml

@@ -21,13 +21,15 @@ on:
         default: false
 
 permissions:
-  contents: write
-  packages: write
+  contents: read
 
 jobs:
   release:
     name: Build, Package, and Distribute
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      packages: write
 
     steps:
       - name: Checkout repository
@@ -85,7 +87,7 @@ jobs:
           cp tsql-scriptdom-core/target/tsql-scriptdom-core-${VERSION}-sources.jar release-assets/tsql-scriptdom-core-${VERSION}-sources.jar
           cp tsql-scriptdom-core/target/tsql-scriptdom-core-${VERSION}-javadoc.jar release-assets/tsql-scriptdom-core-${VERSION}-javadoc.jar
           cd release-assets
-          sha256sum * > SHA256SUMS
+          sha256sum ./* > SHA256SUMS
           cd ..
 
       - name: Create GitHub Release
@@ -96,9 +98,9 @@ jobs:
           VERSION="${RELEASE_VERSION}"
           TAG_NAME="v${VERSION}"
           gh release create "${TAG_NAME}" \
-            release-assets/* \
+            ./release-assets/* \
             --title "Release v${VERSION}" \
-            --generate-notes || gh release upload "${TAG_NAME}" release-assets/* --clobber
+            --generate-notes || gh release upload "${TAG_NAME}" ./release-assets/* --clobber
 
       - name: Deploy to GitHub Packages
         env:

.github/workflows/sonar.yml

@@ -7,6 +7,9 @@ on:
     branches: [ master ]
   workflow_dispatch:
 
+permissions:
+  contents: read
+
 jobs:
   sonar:
     name: SonarCloud Scan
@@ -41,4 +44,4 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-        run: mvn clean verify sonar:sonar --batch-mode
+        run: mvn clean verify sonar:sonar -Dsonar.qualitygate.wait=true --batch-mode