Repository navigation
docs: add CODE_OF_CONDUCT, CHANGELOG, issue template config, and normalize LICENSE - #21
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The reworked .claude/settings.json hook guard converts the guard's blocking exit code 2 into exit 0 when mcswe-v3 is installed, silently disabling the PreToolUse protection.
1 open finding
What changed in this PR
This PR adds community/governance documentation and metadata to the tsql-scriptdom-java repository: a Contributor Covenant Code of Conduct, a Keep a Changelog–style changelog, an issue template chooser configuration, and a normalized MIT LICENSE header (with upstream Microsoft attribution retained in NOTICE.md) so GitHub's licensee detector recognizes the SPDX MIT identifier. It also tweaks the .claude/settings.json PreToolUse hook so containers/agents without mcswe-v3 installed aren't blocked. These are primarily repository hygiene changes with no impact on the Java/Maven source modules.
Changes:
- Add
CODE_OF_CONDUCT.md,CHANGELOG.md, and.github/ISSUE_TEMPLATE/config.yml. - Normalize
LICENSEto a clean SPDX-detectable MIT header, relying onNOTICE.mdfor Microsoft attribution. - Guard the
.claude/settings.jsonhook so a missingmcswe-v3binary doesn't block tool use (introduces a logic bug — see below).
| File | Description |
|---|---|
| LICENSE | Replaces multi-party copyright header with a single standard MIT copyright line for SPDX detection; Microsoft attribution remains in NOTICE.md. |
| CODE_OF_CONDUCT.md | Adds Contributor Covenant v2.1 with an enforcement contact email. |
| CHANGELOG.md | Adds Keep a Changelog baseline with [Unreleased] and [0.1.0] sections. |
| .github/ISSUE_TEMPLATE/config.yml | Disables blank issues and adds Discussions and security-advisory contact links. |
| .claude/settings.json | Guards the PreToolUse hook for environments lacking mcswe-v3; the new conditional swallows the guard's blocking exit code when mcswe-v3 is present. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| { | ||
| "matcher": "Write|Edit|MultiEdit|NotebookEdit|Bash", | ||
| "hooks": [{"type": "command", "command": "cd \"$CLAUDE_PROJECT_DIR\" && mcswe-v3 hook || exit 2"}] | ||
| "hooks": [{"type": "command", "command": "cd \"$CLAUDE_PROJECT_DIR\" && (command -v mcswe-v3 >/dev/null 2>&1 && mcswe-v3 hook || exit 0)"}] |
Closes #11, Closes #12, Closes #13, Closes #15
Summary of Changes
CODE_OF_CONDUCT.mdadopting the Contributor Covenant v2.1..github/ISSUE_TEMPLATE/config.ymldisabling blank issues and directing community questions to GitHub Discussions and vulnerabilities to Private Security Advisories.CHANGELOG.mdadhering to Keep a Changelog / SemVer.LICENSEheader so GitHub'slicenseedetector recognizes the SPDXMITtag (with Microsoft's upstream attribution cleanly maintained inNOTICE.md)..claude/settings.jsonhook so foreign agents/containers withoutmcswe-v3are not blocked.