Repository navigation
Add position scale - #307
Open
cmalinmayor wants to merge 10 commits into
Open
cmalinmayor wants to merge 10 commits into
cmalinmayor wants to merge 10 commits into
Conversation
…and scale back at import
cmalinmayor
requested review from
AnniekStok and
TeunHuijben
and removed request for
AnniekStok
September 25, 2026 00:57
Had to decide on a serious geff import philosophy - to multiply or not to multiply (by scale), that is the question
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 94.34% 94.49% +0.14%
==========================================
Files 64 64
Lines 3876 3940 +64
==========================================
+ Hits 3657 3723 +66
+ Misses 219 217 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After much waffling about whether or not to scale position attributes, this is my current proposal. I branched off #262, which keeps the "default" as pixel units, as opposed to the current main default of "world".