Fix E2E workflow hanging after Playwright Chromium download#1
Open
Matt-Anis wants to merge 3 commits into
Open
Fix E2E workflow hanging after Playwright Chromium download#1Matt-Anis wants to merge 3 commits into
Matt-Anis wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Chapter 5 E2E GitHub Actions workflow to avoid downloading Playwright’s bundled Chromium and instead run tests against the runner’s preinstalled Google Chrome, addressing a hang during browser installation.
Changes:
- Removed the
npx playwright install chromium --with-depsstep from the Chapter 5 E2E workflow. - Updated the Playwright project configuration to use the
chromechannel (system Chrome) for Chromium-based runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests-chapter5/playwright.config.js |
Configures Playwright to use system Chrome via channel: 'chrome'. |
.github/workflows/test-chapter5.yml |
Removes the Playwright browser install step to prevent the workflow hang/timeouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| name: 'chromium', | ||
| use: { ...devices['Desktop Chrome'] }, | ||
| use: { ...devices['Desktop Chrome'], channel: 'chrome'}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current workflow uses
npx playwright install chromium --with-depswhich downloads a 170MB Chromium binary and then hangs silently during the post-extraction phase on GitHub'subuntu-latestrunners, eventually getting killed by the job timeout.GitHub Actions
ubuntu-latestrunners already have Google Chrome pre-installed, so downloading Playwright's own Chromium binary is unnecessary.Fix:
Remove the npx playwright install chromium --with-deps step from the workflow entirely
Add channel: 'chrome' to the Playwright project config, which tells Playwright to use the system Chrome instead of its own binary
This makes the workflow faster and eliminates the hanging issue entirely.
Before:
After