Skip to content

Refactored MD5Hash to use String.Concat and a single MD5 instance per call #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xperiandri merged 1 commit into from
Sep 18, 2026
Merged

Refactored MD5Hash to use String.Concat and a single MD5 instance per call #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/FSharp.Data.GraphQL.Client/Extensions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ open System.Security.Cryptography
/// Extensions for types used by the GraphQL client library.
[<AutoOpen>]
module internal Extensions =

type String with
/// Returns the input string with the first character in upper case.
member this.FirstCharUpper() =
Expand All @@ -20,11 +21,13 @@ module internal Extensions =
member this.FirstCharLower() =
this.Substring(0, 1).ToLowerInvariant() + this.Substring(1)

member this.MD5Hash() =
Encoding.UTF8.GetBytes(this)
|> MD5.Create().ComputeHash
/// Returns a lowercase hex MD5 hash of the UTF-8 bytes of this string.
member this.MD5Hash () =
use md5 = MD5.Create()

md5.ComputeHash (Encoding.UTF8.GetBytes this)
|> Seq.map _.ToString("x2")
|> Seq.reduce (+)
|> String.Concat

/// Basic operations on lists.
module internal List =
Expand Down
Loading