Repository navigation
ci(release): skip git hook install in the release job - #1991
Merged
Merged
Conversation
fro-bot
approved these changes
Oct 30, 2026
fro-bot
left a comment
Owner
There was a problem hiding this comment.
Verdict: PASS
The job-scoped flag reaches the composite setup action's bun install. The installed simple-git-hooks implementation recognizes '1' and exits before installing hooks, achieving the intended release optimization.
Blocking issues
None
Non-blocking concerns
None
Missing tests
None. No additional automated tests are warranted for this narrowly scoped configuration change. Review was static; no tests or build, lint, or type-check commands were run.
Risk assessment (LOW): likelihood of regression, security exposure, or blast radius
Limited to hook installation in the release job on a fresh hosted runner. The explicit release build remains in place; no permissions or public APIs change. Actual timing improvement remains to be confirmed by the next release.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/agent |
| Run ID | 41046558461 |
| Cache | hit |
| Session | ses_e73794d9dffeE3OZbUqtXGRyhI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Semantic Release step takes about 10 minutes. About 8 of those are spent running our pre-push hook twice.
.github/actions/setuprunsbun install, and itspostinstall(simple-git-hooks) installs the repo's git hooks on the release runner. semantic-release then pushes twice, once for the release commit and once for the tag. Each push firespre-push, which runsbun install,lint,buildand a dist diff. CI and the Build release step have already done all of that.Run 41037504998 (v0.130.0) shows the cost:
@semantic-release/gitprepare (commit + push)This sets
SKIP_INSTALL_SIMPLE_GIT_HOOKS: '1'on the Perform Release job. With it set,simple-git-hooksskips installing the hooks, so neither push runs them. The narration watch is intentional and stays as it is.The next release's Semantic Release step should take about 2.5 minutes.