Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
FCC_API_URL, the dashboard pages fall back to the mock student data. In production, the app started without it and showed the mock data instead of failing. Now the app does not start in production unlessFCC_API_URLis set.Changes Made:
util/env.ts: addsFCC_API_URLto the values production requires.__tests__/utils/env.test.ts: a production env withoutFCC_API_URLreports "FCC_API_URL is not set". The test env uses a placeholder URL until the real API URL is confirmed..env.sample: notes that production requiresFCC_API_URL.Development does not change. With
FCC_API_URLempty, the app still uses the mock data server.On Node 26,
pnpm test(325 tests) passes.