getContentID: reject empty multipart class discriminator instead of slice-panic#71
Merged
Alonza0314 merged 2 commits intoMay 7, 2026
Conversation
…panic Signed-off-by: SAY-5 <say.apm35@gmail.com>
Contributor
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Contributor
Author
|
Done — trimmed verbose comments and moved context to the PR description. Thanks @roundspring2003! |
Contributor
|
@Alonza0314 LGTM |
Alonza0314
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes free5gc/free5gc#1039.
getContentIDconstructs a Go field name from a multipartclass=discriminator by slicingfieldName[:1]. When the resolved discriminator is an empty string — sent as""by the client, or trimmed to""by the dash-prefix handler at line 254 — the slice panics withslice bounds out of range [:1] with length 0and crashes any NF whose multipart deserialization path runs through this helper (AMFN1N2MessageTransferand any other endpoint using a discriminator-derived Content-Id tag).Reject the empty case with a clear error so callers see a 4xx instead of the NF crashing.