Skip to content

Both packages read as a stranger: stale text fixed - #1743

Merged
suleimansh merged 1 commit into
mainfrom
stranger-review-follow-up
Aug 28, 2026
Merged

Both packages read as a stranger: stale text fixed#1743
suleimansh merged 1 commit into
mainfrom
stranger-review-follow-up

Conversation

@suleimansh

Copy link
Copy Markdown
Contributor

Last review pass on both packages: I had a fresh session read them as a stranger who has never seen The Framework — package.json, SKILL.md, every SPEC, every source file — and fix only what is false, stale, or still speaks in The Framework's words. No behaviour changes. Nothing is published yet.


🤖 curated · Fable 5, effort high

What was wrong, and what it says now:

  • skill-branches/src/index.SPEC.md claimed the skill's text is exported for a prompt. It isn't since The data branch is agents-data, checked out under .branches/ (#1736) #1739 (the skill is linked into the checkout); the sentence is gone.
  • skill-branches/src/cli.test.SPEC.md said data and agent-… names are refused. The test says the opposite (agent-zzagent-agent-zz); the bullet now matches the test. Also branches/.branches/.
  • agent-driver/src/types.SPEC.md described The Framework's plan/build/review/security/UX pipeline as the driver contract's own business logic. It is now "every prompt is a fresh context", with the caller's sequence only as the example.
  • agent-driver SPECs said "the actions run target" — The Framework's config word. They now say the GitHub Actions driver (github-actions), the package's own name.
  • skill-branches/SKILL.SPEC.md: dropped "installable by a skills catalogue as skills/branches.md" (nothing does that; the skill installs itself under .claude/skills/branches/), and "from the dashboard" → "from the caller's UI".
  • skill-branches/src/worktree.ts: the .d.ts said the session-name charset is "what the system prompt asks for" (the skill asks now); the module header was a PR-slice note; the error string unsafe run idunsafe agent id; the GitRunner parameter was named agent in git.ts/worktree.ts and git everywhere else — it is git now.

Left alone on purpose: "a daemon" / "a dashboard" as example callers, issue numbers and plan labels in doc comments, the history narration in the drivers' doc comments (code-level), and the missing READMEs.

Proof: pnpm -r typecheck clean; skill-branches 117/117, agent-driver 79/79, framework 1471/1471 — all green in a fresh worktree off e0c553fd.

@suleimansh
suleimansh merged commit 6611a77 into main Aug 28, 2026
2 checks passed
@suleimansh
suleimansh deleted the stranger-review-follow-up branch August 28, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant