Both packages read as a stranger: stale text fixed - #1743
Merged
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last review pass on both packages: I had a fresh session read them as a stranger who has never seen The Framework — package.json, SKILL.md, every SPEC, every source file — and fix only what is false, stale, or still speaks in The Framework's words. No behaviour changes. Nothing is published yet.
🤖 curated · Fable 5, effort high
What was wrong, and what it says now:
skill-branches/src/index.SPEC.mdclaimed the skill's text is exported for a prompt. It isn't since The data branch is agents-data, checked out under .branches/ (#1736) #1739 (the skill is linked into the checkout); the sentence is gone.skill-branches/src/cli.test.SPEC.mdsaiddataandagent-…names are refused. The test says the opposite (agent-zz→agent-agent-zz); the bullet now matches the test. Alsobranches/→.branches/.agent-driver/src/types.SPEC.mddescribed The Framework's plan/build/review/security/UX pipeline as the driver contract's own business logic. It is now "every prompt is a fresh context", with the caller's sequence only as the example.agent-driverSPECs said "theactionsrun target" — The Framework's config word. They now say the GitHub Actions driver (github-actions), the package's own name.skill-branches/SKILL.SPEC.md: dropped "installable by a skills catalogue asskills/branches.md" (nothing does that; the skill installs itself under.claude/skills/branches/), and "from the dashboard" → "from the caller's UI".skill-branches/src/worktree.ts: the.d.tssaid the session-name charset is "what the system prompt asks for" (the skill asks now); the module header was a PR-slice note; the error stringunsafe run id→unsafe agent id; theGitRunnerparameter was namedagentingit.ts/worktree.tsandgiteverywhere else — it isgitnow.Left alone on purpose: "a daemon" / "a dashboard" as example callers, issue numbers and plan labels in doc comments, the history narration in the drivers' doc comments (code-level), and the missing READMEs.
Proof:
pnpm -r typecheckclean; skill-branches 117/117, agent-driver 79/79, framework 1471/1471 — all green in a fresh worktree offe0c553fd.