agent-driver speaks for itself, not for the product - #1742
Merged
Conversation
The package's SPECs, shipped doc comments, error strings and defaults still described its old home: "The Framework", "the dashboard", the daemon, a `framework-agent.yml` default, a `claude/framework-` branch, `[framework]` error prefixes. The embedding product is now "the caller"; the product passes its workflow name; the run branch is `claude/<id>`. The shared CLI engine no longer defaults to one driver's name, and the `runClaude` wrapper (public, used only by its tests) is gone. Claude-Session: https://claude.ai/code/session_013KV2g51oWteQWwhuTTwiZX Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read
packages/agent-driveras a stranger, the way I did with the skill. The code is fine; the package still talked as if it were a folder of The Framework. This PR makes it speak for itself. Two names change on the way: theactionsrun branch isclaude/<session id>(noframework-infix), and the product now passes its workflow name instead of the package assuming it.🤖 curated · Fable 5, effort high
Text a package user reads
SPEC.md+ every module and test SPEC: "The Framework", "the dashboard", "the daemon" are gone. The product embedding the package is the caller (one word, in the glossary); its UI is the caller's UI. The stories are otherwise unchanged.codex.SPEC.md/codex.tsclaimed the product announces at startup that the spending cap cannot apply to Codex. The product does no such thing today; the sentence is gone from the package, and the SPEC now says what the package can promise: a caller must not pretend the cap applies..d.ts: thetypes.tsheader no longer narrates decisions (@gemstack/framework CLI: wrap Claude Code (first driver) + localhost dashboard #166 "option A", "the runner seam", "three methods" for four),fake.tsno longer citesFRAMEWORK_FAKEorAiFake/FakeRunner,child-registry.ts/claude-code.ts/actions.tsno longer say "the framework", "the daemon",--browser.Strings a package user sees at runtime
[framework] claude-code prompt aborted,[framework] codex exited (1): …,[framework] fake …, theonEvent threwconsole line: the prefix is gone; the message already names the driver. The MCP temp dir isagent-driver-mcp-.Product defaults baked in
ActionsDriverOptions.workflowno longer defaults toframework-agent.yml; it is required, andcli.tspasses it.actionsrun pushes to isclaude/<session id>(claude/actions-1-ab12cd34), wasclaude/framework-<session id>.branchPrefixstill overrides theclaude/part.Two code things
runCliSessionno longer defaults the driver name toclaude-code;driveris required and the Claude driver passes it.runClaude(a 3-line wrapper, public, used only by its own tests) is gone; the tests callrunCliSessionwithStreamJsonParser.Left alone on purpose — design, not slop
DriverImplIdfixesclaude-web, an implementation that lives outside the package.agent-driver(unscoped) next to@gemstack/skill-branches.filesshipsdistonly; the SPEC is the read on GitHub).runClaude: the session classes, both parsers,replayTranscript,readClaudeQuota, the engine and its types are the extension pointsindex.SPEC.mddescribes.No behaviour change except the two names above. Proof: root typecheck, 79 agent-driver tests, 1471 framework node tests + 864 dashboard tests green.
FEATURES-SPEC.mduntouched: no feature added or removed.