Repository navigation
Phase 1: CI workflow, critical-path tests, and README clarity - #12
Merged
Merged
Conversation
- Add pnpm workspace with lint, typecheck, test, and build scripts - Add GitHub Actions CI on pull requests and main pushes - Test socket auth boundary and text message persistence/broadcast - Test client link parsing and emoji detection utilities - Refresh README with problem statement, architecture, stack, and quick start Co-authored-by: Frainer Encarnación <fraineralex@users.noreply.github.com>
Deploying chatify with
|
| Latest commit: |
f33e15c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f86dfe2.chatify-qny.pages.dev |
| Branch Preview URL: | https://cursor-ci-tests-readme-8b3a.chatify-qny.pages.dev |
fraineralex
marked this pull request as ready for review
September 18, 2026 05:11
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings Chatify to a minimal senior bar for CI and testing without introducing secrets or invented metrics.
CI (
.github/workflows/ci.yaml)mainpnpm install→ lint → typecheck → test → buildpackageManager(avoids pnpm 11+ERR_PNPM_IGNORED_BUILDSissues)sharpnative bindings are available for server testsWorkspace scripts (root
package.json+pnpm-workspace.yaml)pnpm run lint— ESLint on client + server sourcepnpm run typecheck— TypeScript--noEmitpnpm run test— server + client unit testspnpm run build— compile server + production client bundleTests added
server/src/middlewares/auth.test.tsserver/src/controllers/socket.test.tsnewMessagepersists to DB and emitschat_messageclient/src/utils/chat.test.tsclient/src/utils/isOneEmoji.test.tsREADME
Local verification
All steps pass locally:
pnpm install pnpm run lint pnpm run typecheck pnpm run test pnpm run buildNotes