Format JSON refs#24
Open
Kronos3 wants to merge 1 commit into
Open
Conversation
bocchino
requested changes
May 22, 2026
Contributor
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks good, but when I install as described in the README and run python tests/generate_ref_files.py $TOOLS/fpp, I see that some test output files are compressed. There must be some other invocation of fpp-to-json that we missed. Can you look into it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a tandem with nasa/fpp#1004. That PR changes the default
fpp-to-jsonbehavior to dump minimized JSON by default (no whitespace). This PR includes the new option that will generate ref files with whitespace.