Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credentials in the request URL are sent still percent-encoded.
new URL()keepsusernameandpasswordin their encoded form, and since the switch away fromurl.parse()(v9.0.2) they go straight into.auth(), so a user liketobi@example.comcan't be passed in the URL at all.The server receives
Authorization: Basicfortobi%40example.com:learn%20boost%2F. Expectedtobi@example.com:learn boost/, which is whathttp.get()with the same URL sends, and what superagent sent up to 9.0.1.The node client now runs both parts through
decodeURIComponentbefore calling.auth(), like Node'surlToHttpOptionsdoes. A malformed escape such as a bare%zzis kept as it is instead of throwing.Tested with a new case in
test/node/basic-auth.js. On master it fails with:With the fix,
npm run build,npm run lint(no errors, warnings unchanged) andmake testpass on Node 26: 438 passing over HTTP/1 and 432 over HTTP/2.