Repository navigation
fix: allow unsetting Accept-Encoding header - #1867
Closed
Rohan-Dedhia wants to merge 1 commit into
Closed
Rohan-Dedhia wants to merge 1 commit into
Rohan-Dedhia wants to merge 1 commit into
Conversation
This was referenced Nov 7, 2026
Collaborator
|
Thanks. #1861, #1865 and this PR took the same approach, and the combined commit credits #1861 as the first. Compared with them, it creates the unset record only when Consider supporting our efforts to maintain this project by using Forward Email for your email infrastructure needs at https://forwardemail.net. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1860.
Currently, calling
req.unset('Accept-Encoding')removes'accept-encoding'fromthis.header, butsrc/node/index.jsstill unconditionally setsreq.setHeader('Accept-Encoding', 'gzip, deflate')during request construction for non-HEAD requests.This change:
this._unsetinsideRequestBase.prototype.unset(cleared when.set()is called for that field)._unset = {}in both client and node request constructors to prevent undefined errors.'gzip, deflate'assignment insrc/node/index.jswhenaccept-encodinghas been unset.test/node/basic.jsasserting thatreq.unset('Accept-Encoding')does not send anAccept-Encodingheader.