proposal: auto-review primitive for skills#60
Open
JoshSalomon wants to merge 4 commits into
Open
Conversation
Introduces an opt-in review.md file alongside SKILL.md that enables automatic worker→reviewer→fix loops for any skill. Includes two architectural approaches for maintainer discussion, with file-based observability for near-real-time metrics and Jira visibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Interactive script to send Jira webhook payloads to a local Forge instance. Substitutes ticket IDs, and for revision/question payloads fetches the latest comment from Jira via REST API so feedback is always current. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test payloads hardcode issuetype as "Feature", which bypasses parent routing for Epics/Tasks. The script now fetches the real issue type, labels, summary, and status from Jira and injects them into the payload, so child ticket events route correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eshulman2
reviewed
Jun 11, 2026
eshulman2
left a comment
eshulman2
left a comment
Collaborator
There was a problem hiding this comment.
I agree option A is the better option, lets go with this one. please modify the proposal to reflect option A is the chosen one and that option B was considered but wasn't chosen.
Container-internal loop with file-based observability selected for implementation. Approach B retained for reference. Added implementation note about final file sweep and cycle file persistence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
The proposal was updated to reflect the selected approach (option A - in container loop) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a proposal for an opt-in auto-review mechanism as a new primitive for skills. Any skill can include a
review.mdalongsideSKILL.mdto enable automatic worker→reviewer→fix loops.Decision
Approach A (container-internal loop) has been selected for implementation.
The review loop runs inside the container entrypoint. The orchestrator gets near-real-time visibility via file-based polling of per-cycle JSON files written to the shared workspace mount.
Key Design Points
review.mdalongsideSKILL.md— no file means no review, current behavior preservedmax_retriesin review.md frontmatter, global default fallbackFiles Changed
proposals/auto-review-primitive.md— full proposal (Approach A accepted, Approach B retained for reference)proposals/README.md— index entry added🤖 Generated with Claude Code