Fix workflow labels, trace context, and Forge internal file leaks#116
Open
eshulman2 wants to merge 2 commits into
Open
Fix workflow labels, trace context, and Forge internal file leaks#116eshulman2 wants to merge 2 commits into
eshulman2 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forge:ci-pendingtoforge:review-pendingonce CI passesepic_keysmust be derived from implemented task parents.forge/handoff/history files out of generated PR commits via local git excludes and explicit staging guardsVerification
uv run pytest tests/unit/workspace/test_git_ops_redaction.py::test_stage_all_excludes_forge_internal_directory tests/unit/workflow/nodes/test_workspace_setup.py::TestWorkspaceSetupStatusComment::test_workspace_setup_uses_local_git_exclude_for_forge_dir tests/unit/sandbox/test_container_entrypoint_git_commit.py tests/unit/workflow/utils/test_jira_status.py::TestSetReviewPendingLabel tests/unit/workflow/nodes/test_ci_attempt_tracking.py::TestCIAttemptReset::test_current_attempt_resets_on_ci_success tests/unit/workflow/nodes/test_implementation.py::TestImplementTaskStartedComment::test_passes_trace_context_to_container_runner tests/unit/sandbox/test_runner_timeout_cleanup.py::test_run_writes_trace_context_to_task_file tests/unit/workflow/nodes/test_human_review_completion.pyuv run pytest tests/unit/workflow/test_ci_gate_skip.pyuv run ruff check src/forge/workspace/git_ops.py src/forge/workflow/nodes/workspace_setup.py src/forge/workflow/nodes/implementation.py containers/entrypoint.py tests/unit/workspace/test_git_ops_redaction.py tests/unit/workflow/nodes/test_workspace_setup.py tests/unit/sandbox/test_container_entrypoint_git_commit.pypython -m py_compile containers/entrypoint.py