Repository navigation
feat: add 30 Amazon, Walmart and flight entities to SerpApi questions (closes #342) - #347
Conversation
There was a problem hiding this comment.
The additions generally look consistent with the existing source rules. I tested all 90 new entries in serpapi and through the PR’s parsers: 29/30 Amazon, 30/30 Walmart, and 28/30 flights returned valid measurements.
Three entries failed even with fresh retries:
- AirTag (B0933BVK6T): Only third-party seller 6ave offers appeared; no qualifying new Amazon.com offer.
- AR1132 (EZE–MAD): Google returned EZE–GIG / GIG–MAD legs, which do not match the configured airport pair.
- BA7 (LHR–HND): The configured query returned no structured flight-status result, including with caching disabled.
Could these entries be investigated manually or replaced?
The claim that all added flights operate daily also needs checking. Published schedules show QF93 excluding Saturdays during November 15–23, 2026, and Thursdays during November 25–December 2; LH716 excludes Tuesdays during January 13–24, 2027, and Mondays during January 26–February 7.
Minor wording nit: the Burt’s Bees ASIN is a four-pack; adding that quantity would make its description consistent with the other products.
| "asin": "B0000683A4", | ||
| }, | ||
| { | ||
| "id": "b0933bvk6t-amazon-com-new", |
There was a problem hiding this comment.
Only third-party seller offers appeared; no qualifying new Amazon.com offer.
| "destination_name": "London Heathrow Airport", | ||
| }, | ||
| { | ||
| "id": "ar1132-eze-mad", |
There was a problem hiding this comment.
Google returned EZE–GIG / GIG–MAD legs, which do not match the configured airport pair
There was a problem hiding this comment.
The configured query returned no structured flight-status in serpapi results
| "destination_name": "Dallas Fort Worth International Airport", | ||
| }, | ||
| { | ||
| "id": "qf93-mel-lax", |
There was a problem hiding this comment.
no flights Saturdays during November 15–23, 2026, and Thursdays during November 25–December 2
| "destination_name": "Tokyo Haneda Airport", | ||
| }, | ||
| { | ||
| "id": "lh716-fra-hnd", |
There was a problem hiding this comment.
no flights Tuesdays during January 13–24, 2027, and Mondays during January 26–February 7
2b449ec to
42bd531
Compare
|
Thanks for testing all 90, and sorry for only getting back to this now! Updated and rebased on
All replacements return valid measurements through the parsers. |
42bd531 to
5811817
Compare
|
All issues have been addressed. I tried again BA7: this time worked fine. All good! |
3f3b925 to
ed39f2b
Compare
ed39f2b to
7ca4f55
Compare
7ca4f55 to
b674d94
Compare
Adds 30 Amazon products, 30 Walmart groceries and 30 long-haul flights to the SerpApi questions
(#342). Data only; all changes are in
src/sources/serpapi_questions.py.sold by Walmart.com and in stock at its store; store names were checked on Walmart's pages.
under the same number on sample winter and summer 2027 dates.
Testing: local fetches returned valid measurements for all 90. Both SerpApi jobs were deployed
and run in
forecastbench-karolis(240 resolution files).make lintandmake testpass.Cost: daily SerpApi searches go from 150 to 240, about 7,200 credits a month.
🤖 Generated with Claude Code